Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout picker - Update emoji #2103

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Layout picker - Update emoji #2103

merged 4 commits into from
Apr 8, 2020

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Apr 3, 2020

Fixes #2093

Gutenberg PR -> WordPress/gutenberg#21373

To test check the Gutenberg PR description

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux requested review from chipsnyder and mkevins April 3, 2020 14:13
@geriux geriux marked this pull request as ready for review April 3, 2020 14:13
@geriux
Copy link
Contributor Author

geriux commented Apr 3, 2020

Hey @mkevins @chipsnyder 👋

I've added you both to review and test this PR. Since the issue is for Android, could we split the testing in different APIs? I was thinking:

This way we double check all is working correctly.

Thank you!

Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with WordPress/gutenberg#21373 (review) Just pending Matt's review

Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geriux geriux merged commit 5f66424 into develop Apr 8, 2020
@geriux geriux deleted the fix/layout-picker-emoji branch April 8, 2020 07:28
@pinarol pinarol added this to the 1.26 milestone Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template picker: Missing emoji characters in API 21
4 participants