Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode on Android put on the v1.25.0 release #2098

Merged
merged 25 commits into from
Apr 3, 2020
Merged

Dark Mode on Android put on the v1.25.0 release #2098

merged 25 commits into from
Apr 3, 2020

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Apr 2, 2020 •
edited
Loading

Follow up to #2061 to bring the Dark Mode Android feature on top of the v1.25.0 release.

Related PRs

Gutenberg: WordPress/gutenberg#21352
WPAndroid PR: wordpress-mobile/WordPress-Android#11580

To test:

  1. Test out that Can't scroll longer Post after dark mode is implemented #2056 is fixed
  2. Do a full sweep of the manual testsuite (Issue/fix gb paragraph scroll issue WordPress-Android#11569 (comment)) to gain confidence no new regression is introduced.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

marecar3 and others added 23 commits March 25, 2020 09:43
@marecar3
Update gb reference
b381555
@marecar3
Revert revert of dark mode impl.
cc10521
@marecar3
Merge branch 'develop' into feature/1675-dark_mode_android_integratio…
b7f85c5 
…n_new

# Conflicts:
#	gutenberg
@marecar3
Update gb reference
7a2be76
@SergioEstevao
Update GB reference
59c801d
@marecar3
Merge branch 'develop' into feature/1675-dark_mode_android_integratio…
c2d0363 
…n_new

# Conflicts:
#	gutenberg
@marecar3
Update gb reference
b9ce723
@SergioEstevao
Update Gutenberg reference
9e88f0a
@SergioEstevao
Update GB reference
eb91edd
@SergioEstevao
Update GB reference.
a8055c7
@SergioEstevao
Update GB reference.
59a5213
@SergioEstevao
Merge branch 'develop' into issue/fix_pre_style
b47542f 
# Conflicts:
#	gutenberg
@SergioEstevao
Update GB reference
c9df8b0
@SergioEstevao
Update GB reference.
b48876f
@SergioEstevao
Update GB reference.
da7d3bc
@SergioEstevao
Update GB reference.
13f3a95
@marecar3
Align with master
1b7ab14
@marecar3
Update gb reference
d364d98
@SergioEstevao
Merge pull request #2083 from wordpress-mobile/issue/fix_pre_style
4783f25 
Fix pre block style to use monospace font.
@marecar3
Trigger Jitpack
9390e00
@marecar3
Update gb reference
8f99673
@marecar3
Merge branch 'develop' into feature/1675-dark_mode_android_integratio…
14d5995 
…n_new
@hypest
Merge branch 'feature/1675-dark_mode_android_integration_new' into re…
2e1d787 
…lease/1.25.0-with-dark-mode
@hypest hypest added this to the 1.25 milestone Apr 2, 2020
@SergioEstevao SergioEstevao mentioned this pull request Apr 2, 2020
Merged
4 tasks
@hypest hypest mentioned this pull request Apr 3, 2020
Merged
3 tasks
@hypest hypest mentioned this pull request Apr 3, 2020
Merged
6 tasks
@hypest hypest marked this pull request as ready for review April 3, 2020 12:43
@hypest hypest requested a review from marecar3 April 3, 2020 12:43
marecar3
marecar3 approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@SergioEstevao SergioEstevao merged commit 0966461 into release/1.25.0 Apr 3, 2020
@marecar3 marecar3 mentioned this pull request Apr 3, 2020
Closed
3 tasks
@hypest hypest deleted the release/1.25.0-with-dark-mode branch April 3, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

Assignees
No one assigned
Labels
Dark mode
Projects
None yet
Milestone
1.25
Development

Successfully merging this pull request may close these issues.
3 participants
@hypest @marecar3 @SergioEstevao