Color Settings #2096
Merged
Color Settings #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
lukewalczak
force-pushed
the
color-picker
branch
2 times, most recently
from
42d2e42 to
546ff10
Compare
|
Is this ready to code review? |
lukewalczak
force-pushed
the
color-picker
branch
from
96905a3 to
4b9528c
Compare
geriux
approved these changes
May 5, 2020
There was a problem hiding this comment.
LGTM! Approved via WordPress/gutenberg#21326 (review)
Let's not forget to remove the bundles, etc. Nice work! 🎉 👏
geriux
reviewed
May 5, 2020
RELEASE-NOTES.txt
Outdated
| @@ -11,6 +11,7 @@ | |||
| * Fix Quote block so it visually reflects selected alignment | |||
| * Fix bug where buttons in page templates were not rendering correctly on web | |||
| * New block: Pullquote | |||
| * Add support for changing background and text color in Buttons block | |||
There was a problem hiding this comment.
FYI this should go in 1.28.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1692
Ref to testing wp-ios: wordpress-mobile/WordPress-iOS#13690
Ref to testing wp-android: wordpress-mobile/WordPress-Android#11571
Ref to gutenberg: WordPress/gutenberg#21326
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.