Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BottomSheet breakage related to @wordpress/interface #2085

Merged
merged 4 commits into from
Mar 31, 2020
Merged

Fix BottomSheet breakage related to @wordpress/interface #2085

merged 4 commits into from
Mar 31, 2020

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Mar 31, 2020 •
edited
Loading

This PR makes us target gutenberg master and fixes the regressions related to the introduction of the @wordpress/interface package.

Gutenberg PR: WordPress/gutenberg#21291

To test: Do manual tests to spot regressions

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Tug Tug requested a review from SergioEstevao March 31, 2020 12:45
@Tug Tug self-assigned this Mar 31, 2020
@Tug Tug force-pushed the fix/bottomshee-breakage branch from 268d173 to be33c9a Compare March 31, 2020 15:42
@Tug Tug force-pushed the fix/bottomshee-breakage branch from be33c9a to e5d5cfb Compare March 31, 2020 15:48
SergioEstevao
SergioEstevao approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SergioEstevao SergioEstevao merged commit 94c43be into develop Mar 31, 2020
@SergioEstevao SergioEstevao deleted the fix/bottomshee-breakage branch March 31, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees

@Tug Tug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tug @SergioEstevao