Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cell alignment on image settings for Android #2079

Merged
merged 5 commits into from
Mar 30, 2020
Merged

Fix cell alignment on image settings for Android #2079

merged 5 commits into from
Mar 30, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Mar 28, 2020 •
edited
Loading

This PR updates the GB reference where the alignment issue is fixed.

To test:

  • Start the demo app in Android
  • Open the image selection options
  • Check if bottom sheet show options left aligned
  • Check other uses of bottom sheets in settings and alignment options

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added this to the 1.25 milestone Mar 28, 2020
@etoledom
Copy link
Contributor

Gutenberg side PR: WordPress/gutenberg#21227

etoledom
etoledom approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like a charm!
Thank you @SergioEstevao 🙏

@SergioEstevao SergioEstevao added the [Type] Bug Something isn't working label Mar 30, 2020
@SergioEstevao SergioEstevao merged commit b9ecac3 into develop Mar 30, 2020
@SergioEstevao SergioEstevao deleted the issue/fix_cell_align branch March 30, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

Assignees
No one assigned
Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
1.25
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioEstevao @etoledom