Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Border reimplementation #2050

Merged
merged 4 commits into from
Mar 25, 2020
Merged

Block Border reimplementation #2050

merged 4 commits into from
Mar 25, 2020

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented Mar 23, 2020

Fixes #1948
Gutenberg PR - WordPress/gutenberg#20769
To test:

  • App should look exactly the same as before.
  • Please focus on checking borders of selected/unselected blocks in inner blocks

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

This was referenced Mar 23, 2020
Merged
Closed
pinarol
pinarol approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with the steps in the gutenberg PR.

@dratwas dratwas force-pushed the block-borders-reimplementation branch from cae5840 to 0f6f52b Compare March 25, 2020 14:16
@dratwas dratwas merged commit 3772fcf into develop Mar 25, 2020
@dratwas dratwas deleted the block-borders-reimplementation branch March 25, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dratwas @pinarol