-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the react-native-hr library to GB mobile #205
Conversation
This reverts commit 23f8670.
👋 @pinarol , is there perhaps a GB-web side branch or PR to link with in this PR? I don't see GB-web ref being updated or a PR referenced so, not sure how to test this one? Thanks! |
right let's wait for #209 firstly |
# Conflicts: # gutenberg
This is for being able to test the new Hr element
this is ready to review @hypest I updated the GB-web ref to include the example usage |
Hey @pinarol - This is looking great! 🎉 I couldn't find the Thank you! |
# Conflicts: # gutenberg
I notice that the Gutenberg side PR only touches Now, we do actually know that the import on the GB side will break against current mobile master in some way so, let's review and give the green light here and then quickly merge the GB side, update this PR's ref and merge it too. The total disruption to mobile master will be small. WDYT? |
@hypest I agree, it looks like it won't be a problem as soon as I'm quick between PR merges. So once PR reviews are done I can just merge GB PR and then update this PR's ref and merge it too 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great and all tests are passing (so far 😅)
@pinarol - All yours to do the merge magic!
We know that there's a known issue with travis checks currently and we are working on it, but we decided to merge this immediately in order not to cause compile errors on local working environments since a new library is introduced with this PR and it is already imported from the gutenberg submodule. |
This is a simple PR that adds the react-native-hr library to GB mobile. It will be used by the nextpage block. Usage can be found in this PR.
I've updated the submodule ref to point to the gutenberg branch that uses the new Hr element. So you can open the demo app and verify that there is a text-surrounding line in the Page break element which is brought us by this new Hr element: