Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update page template picker after design review #2020

Merged
merged 5 commits into from
Mar 17, 2020
Merged

Update page template picker after design review #2020

merged 5 commits into from
Mar 17, 2020

Conversation

koke
Copy link
Member

@koke koke commented Mar 16, 2020

See #2012
Gutenberg PR: WordPress/gutenberg#20883

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@koke koke mentioned this pull request Mar 16, 2020
Merged
6 tasks
@koke koke requested a review from geriux March 16, 2020 08:36
@koke koke added this to the 1.24 milestone Mar 16, 2020
@koke koke marked this pull request as ready for review March 16, 2020 08:37
geriux
geriux approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#20883 (review)

@marecar3
Copy link
Contributor

marecar3 commented Mar 16, 2020 •
edited
Loading

We're freezing 1.24.0 today. If you think it is ready and if you'd like to ship it with 1.24.0please merge it into develop branch. Otherwise, we can bump it to 1.25.0. @koke @geriux

@koke koke merged commit 4a41901 into develop Mar 17, 2020
@koke koke modified the milestones: 1.24, 1.25 Mar 17, 2020
@dcalhoun dcalhoun deleted the spt-design-fixes branch August 28, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees
No one assigned
Labels
Page Templates
Projects
None yet
Milestone
1.25
Development

Successfully merging this pull request may close these issues.
3 participants
@koke @marecar3 @geriux