Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss bottom sheet on return key submit #2009

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Mar 12, 2020

Addresses #1164

To test: See WordPress/gutenberg#20848

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@guarani guarani added the [Status] DO NOT MERGE Do not merge this PR label Mar 12, 2020
@guarani
Copy link
Contributor Author

guarani commented Mar 12, 2020

Since using a forked Gutenberg here, this PR needs to be updated before merging.

@guarani guarani marked this pull request as ready for review March 13, 2020 15:06
@mchowning
Copy link
Contributor

What do you think about adding a release note for this change?

@guarani
Copy link
Contributor Author

guarani commented Mar 16, 2020

What do you think about adding a release note for this change?

@mchowning, good question. I'm leaning towards this being too trivial of a change to warrant inclusion in the release notes, but I could be wrong. If we were going to add it, it could be something like this:

"Block Editor: When editing link settings, tapping the keyboard return button now closes the settings panel as well as closing the keyboard."

@mchowning
Copy link
Contributor

I'm leaning towards this being too trivial of a change to warrant inclusion in the release notes

It seems like a user-facing change to me, so I think it should be added to the release notes. Your suggested release note sounds good to me.

@guarani guarani added this to the 1.25 milestone Mar 16, 2020
@guarani guarani force-pushed the rnmobile/dismiss-bottom-sheet-on-submit branch from 1b80e41 to 01012a9 Compare March 17, 2020 14:05
@guarani guarani force-pushed the rnmobile/dismiss-bottom-sheet-on-submit branch 3 times, most recently from 3bedca0 to 2d0e4df Compare March 27, 2020 14:44
@guarani guarani removed the [Status] DO NOT MERGE Do not merge this PR label Mar 27, 2020
@guarani guarani force-pushed the rnmobile/dismiss-bottom-sheet-on-submit branch from 2d0e4df to 4bf95f0 Compare March 27, 2020 14:47
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well! Nice job! :shipit:

@guarani guarani merged commit df37c28 into develop Mar 27, 2020
@guarani guarani deleted the rnmobile/dismiss-bottom-sheet-on-submit branch March 27, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants