Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Media Icon #2007

Merged
merged 5 commits into from
Mar 13, 2020
Merged

Replace Media Icon #2007

merged 5 commits into from
Mar 13, 2020

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Mar 12, 2020

Fixes #1476 (last one of the checklist)

Gutenberg PR -> WordPress/gutenberg#20841

To test check the Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux requested a review from koke March 13, 2020 09:15
@geriux
Copy link
Contributor Author

geriux commented Mar 13, 2020

Hey @koke 👋 I've assigned this PR to you if you have time to test it, it's a quick one 😬

Basically just to see that the icon shows up correctly, the testing information is in the Gutenberg PR.

Thank you!

Copy link
Member

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, and those new icons look fancy 😁

Gerardo Pacheco added 2 commits March 13, 2020 13:24
@geriux geriux merged commit 12ba05f into develop Mar 13, 2020
@geriux geriux deleted the feature/replace-icon branch March 13, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media & Text block design review
2 participants