Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for heading alignment buttons #1990

Merged
merged 14 commits into from
Mar 25, 2020
Merged

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Mar 9, 2020

Fixes #1880

Gutenberg PR: WordPress/gutenberg#20745

This PR updates the GB reference to add support to alignment on the Heading block.
In the process, the heading block was refactored to share all the edit method with the web and that that involved using the new Text component that needed the adding of the emotion style library.
We now have support for dropdown menu in the block control. The implementation uses a BottomSheet to show the options when tapped.

To test:

  • Open the demo app
  • Add a Heading block
  • Check if the alignment options are visible on the block toolbar
  • Check if the alignment options work correctly.
  • Check if the header size show and work correctly on the toolbar

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Add emotion library to project to support styled Text component.
@SergioEstevao SergioEstevao added [Type] Enhancement Improves a current area of the editor Blocks labels Mar 9, 2020
@SergioEstevao SergioEstevao added this to the 1.24 milestone Mar 9, 2020
@SergioEstevao SergioEstevao requested a review from Tug March 9, 2020 21:35
@iamthomasbishop
Copy link
Contributor

Thank you for working on this! It'll be beneficial for a bunch of blocks/features <3

@SergioEstevao
Copy link
Contributor Author

SergioEstevao commented Mar 10, 2020

@mchowning is going to check why the align commands don't work on Android.

@mchowning
Copy link
Contributor

I have opened an AztecEditor-Android PR that should address the alignment issue we're seeing here on Android.

@marecar3
Copy link
Contributor

We're freezing 1.24.0 today. If you think it is ready and if you'd like to ship it with 1.24.0please merge it into develop branch. Otherwise, we can bump it to 1.25.0. @SergioEstevao @Tug

@Tug Tug modified the milestones: 1.24, 1.25 Mar 25, 2020
Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SergioEstevao
Copy link
Contributor Author

I'm merging this PR and doing a follow up PR to disable the options to align in Android if Aztec Android is not until next Friday.

@SergioEstevao SergioEstevao merged commit 8f3784d into develop Mar 25, 2020
@SergioEstevao SergioEstevao deleted the issue/heading_align branch March 25, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add text-alignment support to Headings
5 participants