-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for heading alignment buttons #1990
Conversation
Add emotion library to project to support styled Text component.
Thank you for working on this! It'll be beneficial for a bunch of blocks/features <3 |
@mchowning is going to check why the align commands don't work on Android. |
I have opened an AztecEditor-Android PR that should address the alignment issue we're seeing here on Android. |
We're freezing |
# Conflicts: # gutenberg
# Conflicts: # gutenberg # react-native-aztec/android/build.gradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm merging this PR and doing a follow up PR to disable the options to align in Android if Aztec Android is not until next Friday. |
Fixes #1880
Gutenberg PR: WordPress/gutenberg#20745
This PR updates the GB reference to add support to alignment on the Heading block.
In the process, the heading block was refactored to share all the edit method with the web and that that involved using the new Text component that needed the adding of the emotion style library.
We now have support for dropdown menu in the block control. The implementation uses a BottomSheet to show the options when tapped.
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.