Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] remove Yarn preios step #1927

Merged
merged 1 commit into from
Feb 18, 2020
Merged

[CI] remove Yarn preios step #1927

merged 1 commit into from
Feb 18, 2020

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented Feb 18, 2020

I realized that we don't need the CI Yarn preios step anymore since the preios is run in the build step. Recently I updated the test:e2e:build-app:ios script to use yarn ios under the hood sot the preios is also run.

To test:

  • Green CI (it affects only CI)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

SergioEstevao
SergioEstevao approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dratwas dratwas merged commit be730e4 into develop Feb 18, 2020
@dratwas dratwas deleted the fix/remove-unused-CI-step branch February 18, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dratwas @SergioEstevao