e2e test update ios simulators versions #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dratwas
approved these changes
Feb 18, 2020
| browserName: '', | ||
| platformName: 'iOS', | ||
| platformVersion: '13.0', | ||
| deviceName: 'iPhone 11 Simulator', | ||
| platformVersion: '13.3', |
There was a problem hiding this comment.
I think that the platformVersion and deviceName could be removed from here since the ios is not exported. They are declared in iosLocal and iosServer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just updates the simulators being used for e2e tests and refactor the code a bit to make clear what simulators are used in CI and the one used locally.
To test:
yarn test:e2e:ios:localPR submission checklist:
RELEASE-NOTES.txtif necessary.