Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link button on Rich Text #1879

Merged
merged 8 commits into from
Feb 14, 2020
Merged

Fix link button on Rich Text #1879

merged 8 commits into from
Feb 14, 2020

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Feb 11, 2020

Fixes #1875
gutenberg PR: WordPress/gutenberg#20172

This PR updates the gutenberg ref to bring a fix on isURL that will fix the mentioned issue on the LinksUI Modal.

Gif showing the issue:

link_button

To test:

To test:

  1. Select some text on a Paragraph block (or any rich text powered block)
  2. Tap on the links button on the block's the action bar.
  3. Check that the Modal with the links options show as expected.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added this to the 1.23 milestone Feb 11, 2020
@etoledom etoledom self-assigned this Feb 11, 2020
@etoledom etoledom marked this pull request as ready for review February 11, 2020 17:55
Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@etoledom etoledom merged commit 49014bb into develop Feb 14, 2020
@etoledom
Copy link
Contributor Author

Thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rich Text]: Links button won't show links settings
2 participants