-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Button block in production #1866
Conversation
I am copy/pasting test cases here to be checked after testing: WPiOS:
WPAndroid:
|
@geriux -> WPAndroid Please use peril links in the parent PRs to install the app for testing. And check these items when done with testing. Keep in mind that you don't have to limit yourselves with those items, challenging the feature in different ways is always welcomed. |
Had a chance to go through and test extensively, here are my notes. Note: Most issues were present across both platforms (platform-specific issues are labeled as such). Blockers
Non-blockers
|
Thanks @iamthomasbishop for the valuable feedback! 👌 To avoid confusions I would like to ask for some details:
Unfortunately, a screenshot is not loading and tbh I don't know what color you meant, because please note that
I think it can be related to the Android API version, but would like to get more insights from @chipsnyder who was working on that (is there any obstacle to support it?). On API level 27 handles have correct bg color, for the reference:
Didn't see that in the requirements, but I see no reason why don't support it ✌️ . |
Sorry, I should have been clearer in my feedback. I meant to say that the background color should be gray both when the user creates a new button block on mobile and when there is a fallback. The reason for this is — and correct me if I’m wrong — is that when a user creates a new button on mobile, it is setting the background to the theme-default color. In other words, creating a new button on mobile results (on the front-end) in a button with the theme’s default style. For example, if I’m using the Twenty-Twenty theme and I create a button on mobile, it’s going to be a pink squared-off button. Because we don’t have access to that style information, we should keep the background color neutral.
Good to know. 👍
I’m not sure if it was in the initial requirements, so it could be something to iterate on, but I just wanted to document it 😀 |
UPDATES - RESOLVE ALL BLOCKERS:
|
Tested the |
Tested on Android using wordpress-mobile/WordPress-Android#11256 (comment) By following these test cases #1866 (comment) All working great ✅, orientation changes, using it within the |
Couldn't test the latest changes though since the latest build doesn't include them and those were marked as blockers by @iamthomasbishop |
This is correct. The handles should be working in API 27. Although in API 28, there isn't a supported mechanism for it. Then in API 29 we would be able to support it once we bump Aztec to support API 29. |
UPDATES - RESOLVE NON-BLOCKERS
That's true and the problem exists in
Please check the @chipsnyder's answer above.
Via @pinarol: I see this as another iteration after shipping this version>
I've updated the color (43% alpha of white)
I hope I understood it correctly and it looks properly right now:
Updated!
Done 🎉 ! Please check the screenshot above on the right side.
Done 🎉! Also please take a look at the same screenshot! |
This is highly related with Buttons block work, it'd be better if we handle that as a part of that work. And we shouldn't delay it much, because the standalone Button block is kinda deprecated and it should be used inside Buttons block only. |
NEW TEST CASES WPiOS:
WPAndroid:
|
Tested the new build with new test cases and everything works great, however, I found an issue related to the Steps to reproduce:
|
Thanks for reporting that @dratwas. Right, it looks like a general problem about pasting links. |
Tested again with the new cases and all working great! 🎉 ✅ Button block - New Button is created with the gray color By the way regarding to this:
Happens with any text even if they don't have any link in it. So you can add it in the issue as well @dratwas =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but let's wait for @iamthomasbishop's OK on the design changes =)
Great work 👏
Most everything is looking good, so I think we can ship the block now and iterate. I have one clarification regarding the selection outline, which isn't a blocker. I'm still seeing the outline as "inside" the button, whereas I was hoping that it could be "outside" (similar to how box-shadow is applied, to the outside of the element). Here's a diagram to better explain the preferred styling: The benefit of placing the outline outside would be that it should prevent the button from "jumping" on the canvas — it stays in place. I also agree with @pinarol's comment regarding alignment. I had forgotten that the Buttons block was recently introduced and will "deprecate" the Button block:
|
@iamthomasbishop thanks for an explanation! I think I've found the desired solution:
|
That's looking great, just tried out the newest test build! ! |
LGTM! Tested again on Android with the latest changes. Great work! |
Tested on iOS and everything works as expected :) Good job @lukewalczak 🎉 |
61a8d09
to
e445fce
Compare
Unblocking a
Button
block in the productionRef to gutenberg: WordPress/gutenberg#20093
To test:
https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/button.md
PR submission checklist:
RELEASE-NOTES.txt
if necessary.