Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aztec to 1.16.0 #1857

Merged
merged 4 commits into from
Feb 17, 2020
Merged

Update aztec to 1.16.0 #1857

merged 4 commits into from
Feb 17, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Feb 5, 2020

Updates Aztec to version 1.16.0

To test:

  • Start the demo app
  • Smoke test the demo content, especially the list block indents with ordered lists.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added this to the 1.22 milestone Feb 5, 2020
@SergioEstevao SergioEstevao changed the base branch from release/1.22.0 to develop February 6, 2020 10:40
@etoledom
Copy link
Contributor

etoledom commented Feb 7, 2020

@SergioEstevao - shouldn't this target the release branch? 🤔
cc @hypest

@SergioEstevao SergioEstevao modified the milestones: 1.22, 1.23 Feb 8, 2020
@SergioEstevao
Copy link
Contributor Author

@etoledom, because this is not fixing any regression specific for this version we decided to merge to develop.

Can you review it after the 1.22.0 is merged on develop?

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergioEstevao - I have updated from develop and tested. Everything looks good!

Maybe we could add an entry to the release notes about fixing the layout of ordered lists with large numbers (Unless it's already listed on WPiOS)

@SergioEstevao SergioEstevao merged commit d8811f9 into develop Feb 17, 2020
@SergioEstevao SergioEstevao deleted the update_aztec_to_1.16.0 branch February 17, 2020 12:35
@mchowning
Copy link
Contributor

👋 @SergioEstevao and @etoledom ! Just wanted to sanity check that it is fine that react-native-aztec/ios/Cartfile still has a "1.15.0" version.

@SergioEstevao
Copy link
Contributor Author

SergioEstevao commented Feb 17, 2020

Yep it's ok since we upgrade to RN 0.61.5 that file is completely ignored, what matters now is what is defined in RNTAztecView.podspec

@mchowning
Copy link
Contributor

since we upgrade to RN 0.61.5 that file is completely ignored

Could we delete it?

@SergioEstevao
Copy link
Contributor Author

SergioEstevao commented Feb 18, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants