-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aztec to 1.16.0 #1857
Update aztec to 1.16.0 #1857
Conversation
@SergioEstevao - shouldn't this target the release branch? 🤔 |
@etoledom, because this is not fixing any regression specific for this version we decided to merge to develop. Can you review it after the 1.22.0 is merged on develop? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SergioEstevao - I have updated from develop and tested. Everything looks good!
Maybe we could add an entry to the release notes about fixing the layout of ordered lists with large numbers (Unless it's already listed on WPiOS)
👋 @SergioEstevao and @etoledom ! Just wanted to sanity check that it is fine that |
Yep it's ok since we upgrade to RN 0.61.5 that file is completely ignored, what matters now is what is defined in |
Could we delete it? |
I think so, now that we deleted the sample project for RNTAztecView I don't
see the need to have this file anymore, I will give it a go.
…On Mon, 17 Feb 2020 at 22:36, Matt Chowning ***@***.***> wrote:
since we upgrade to RN 0.61.5 that file is completely ignored
Could we delete it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1857?email_source=notifications&email_token=AAE7CUMUAVJVQK4CIHMO2KDRDMGNFA5CNFSM4KQT5LO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL72OQI#issuecomment-587179841>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE7CUPNSAHKOH2YFCEDL5TRDMGNFANCNFSM4KQT5LOQ>
.
|
Updates Aztec to version 1.16.0
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.