Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added list block ordered button e2e test #1806

Merged
merged 5 commits into from
Jan 31, 2020

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Jan 23, 2020

This change should be merged to develop after WordPress/gutenberg#19818 or a similar fix is merged into develp, otherwise the new test will (and should) fail.

Background

Fixes #1805
WordPress/gutenberg#19818 fixed a crash on a release branch that was found from pressing the ordered list button on List Block that was caused by a change in Gutenberg (WordPress/gutenberg#19536).

Description

This change adds the ordered list button press to our Appium tests so any related issues will be caught in the future.

New Test:

__device-tests__/gutenberg-editor-lists.test.js
'should be able to add a new List block'

  1. Select List Block.
  2. Press any of the controls (i.e: Change the list type to ordered).
  3. Verify HTML shows ordered list

To test:

Run with yarn test:e2e:ios:local gutenberg-editor-lists.test.js and yarn test:e2e:android:local gutenberg-editor-lists.test.js

*Note: this change should show a failed test on branches that do not yet include the fix from WordPress/gutenberg#19818, and it should pass on branches that have that fix.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@cameronvoell cameronvoell marked this pull request as ready for review January 23, 2020 05:23
@cameronvoell cameronvoell added the Testing Anything related to automated tests label Jan 23, 2020
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Good to see the test failing after tapping the list type change button :). Here's the button tapping that causes the red screen, recorded in the Saucelabs testrun: https://app.saucelabs.com/tests/66b8b410d415402198d6ad4aae6cc010?auth=bdf07e59796c65673ac609ba29f25381#50

We could merge this PR but since the test will fail (by design), it will block all PRs that follow it until the fix is merged (currently merged only in the v1.21.0 release branches). I'd suggest we wait until after the release is merged back to develop. WDYT?

@cameronvoell
Copy link
Contributor Author

I'd suggest we wait until after the release is merged back to develop. WDYT?

Agreed! I'll catch this PR back up with develop when the List Block fix is merged there, and consider this PR ready once CI all passes.

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!

@cameronvoell
Copy link
Contributor Author

Now that the the numbered list fix checked by this test is merged into develop, tests are passing on the PR, and the new test is ready to be merged to develop.

@cameronvoell cameronvoell merged commit 976e8ae into develop Jan 31, 2020
@cameronvoell cameronvoell deleted the test/list-block-toolbar-buttons branch January 31, 2020 23:49
@hypest hypest mentioned this pull request Feb 3, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Anything related to automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e (Appium) test to catch List Block ordered/unordered button crash
3 participants