[Experimental][emotion] Add button component #1684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dratwas
force-pushed
the
experimental/button/emotion
branch
from
57d436b to
5112c36
Compare
|
Any learnings we can pick out of this PR? Can we close otherwise? |
|
Hey @hypest my takeaways from these experiments (button and box) are listed here https://mobilegutenpagesp2.wordpress.com/2020/01/14/x-platform-button-experimental/ |
|
Thanks for the pointer Piotr! I understand that the this PR is not scheduled for resuming yet so, WDYT about closing? We can always re-open if needed. |
|
Yeah, let's close it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an exploration of x-platform style system. #1411
This is the second iteration on #1386
Gutenberg PR - WordPress/gutenberg#19179