Fork native variant of withViewportMatch HOC to use withSelect again #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR forks
with-viewport-match.jsto a native variant (with-viewport-match.native.js) to revert changes introduced in this PR: WordPress/gutenberg#18950 for mobile only.Related gutenberg PR: WordPress/gutenberg#19027
How has this been tested?
The withViewportMatch HOC is used in Gallery to limit displayed columns to 2 in portrait mode. This has been tested by adding 3 or more images to a gallery block and ensuring that only 2 columns are displayed in portrait mode (up to 4 in landscape). Also, using the debugger,
isNarrowflag is confirmed to be true for portrait.Update release notes:
RELEASE-NOTES.txt.