Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure if the textColor is changed the default text color is updated. #1653

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

SergioEstevao
Copy link
Contributor

This change make sure that if the textColor prop is set explicitly we also update the defaultTextColor is used in TextView

To test:

  • Try to change the prop style on RichText uses to something like: style={ { color: 'red' }}
  • See if the color is applied.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@SergioEstevao SergioEstevao added the [Type] Bug Something isn't working label Dec 5, 2019
@SergioEstevao SergioEstevao added this to the 1.19 milestone Dec 5, 2019
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixing the regression we are having 👍 I can see that the captions are white again.

Screen Shot 2019-12-05 at 15 17 25

@SergioEstevao SergioEstevao merged commit 8e9a59f into develop Dec 5, 2019
@SergioEstevao SergioEstevao deleted the issue/fix_setting_text_color branch December 5, 2019 13:48
@dratwas dratwas mentioned this pull request Dec 6, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants