Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating gutenberg ref, fix for crash on pasting formatted text. #1617

Closed
wants to merge 1 commit into from
Closed

Updating gutenberg ref, fix for crash on pasting formatted text. #1617

wants to merge 1 commit into from

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Nov 26, 2019 •
edited
Loading

Fixes https://app.circleci.com/jobs/github/wordpress-mobile/gutenberg-mobile/17951/tests

gutenberg PR: WordPress/gutenberg#18740

Video of crash:

crash-on-paste-formatted

To test:

Note that with the updated gutenberg ref that adds a check for undefined, we are now seeing all Android on device tests passing.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@cameronvoell cameronvoell mentioned this pull request Nov 26, 2019
Closed
6 tasks
@cameronvoell cameronvoell marked this pull request as ready for review November 26, 2019 04:43
@etoledom etoledom added Testing Anything related to automated tests bugfix labels Nov 26, 2019
@cameronvoell
Copy link
Contributor Author

Closed, in favor of #1626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom Awaiting requested review from etoledom

Assignees
No one assigned
Labels
bugfix Testing Anything related to automated tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cameronvoell @etoledom