Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash which occurs after deleting image or page break block #1582

Merged
merged 3 commits into from
Nov 15, 2019
Merged

Fix crash which occurs after deleting image or page break block #1582

merged 3 commits into from
Nov 15, 2019

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Nov 15, 2019 •
edited
Loading

Fixes: wordpress-mobile/WordPress-Android#10491

Gutenberg PR: WordPress/gutenberg#18539
WPAndroid PR: wordpress-mobile/WordPress-Android#10805

To test:
Steps to repro - Case A

  • Create a new post
  • Click on the empty paragraph block
  • Add a Page break block
  • Click on the "bin" on the Page break block
  • Page break block should be deleted as expected

Steps to repro - Case B

  • Create a new post
  • Add a Page break block
  • Click on the "bin" on the Page break block
  • This time the block is removed without a crash_
  • Add a Page break block
  • Click on the "bin" on the Page break block
  • Page break block should be deleted as expected

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@marecar3 marecar3 added this to the 1.17 milestone Nov 15, 2019
@marecar3 marecar3 self-assigned this Nov 15, 2019
@marecar3 marecar3 changed the base branch from develop to release/1.17 November 15, 2019 12:53
@marecar3 marecar3 mentioned this pull request Nov 15, 2019
Closed
1 task
@marecar3 marecar3 changed the title Hotfix/crash which occurs after deleting image or page break block Fix crash which occurs after deleting image or page break block Nov 15, 2019
This was referenced Nov 15, 2019
Merged
Merged
Merged
@hypest
Copy link
Contributor

hypest commented Nov 15, 2019

Works for me and fixes the block deletion issue!

SergioEstevao
SergioEstevao approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS and Android and all working great!

@marecar3 marecar3 merged commit 77ffeea into release/1.17 Nov 15, 2019
@marecar3 marecar3 deleted the hotfix/crash-which-occurs-after-deleting-Image-or-Page-break-block branch November 15, 2019 15:38
@cameronvoell cameronvoell mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@hypest hypest Awaiting requested review from hypest

@mchowning mchowning Awaiting requested review from mchowning

@etoledom etoledom Awaiting requested review from etoledom

Assignees

@marecar3 marecar3

Labels
bugfix
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.
3 participants
@marecar3 @hypest @SergioEstevao