-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image size picker improvements #1574
Conversation
…enberg reference.
👋 Cameron, is this PR still relevant? If yes, let's retarget it, thanks! |
c898818
to
a93dd36
Compare
Thank you @cameronvoell for the update! @iamthomasbishop - What do you think about this (temporal) solution for the Image Sizes picker? |
@etoledom @cameronvoell It looks pretty solid overall, based on the test build I grabbed here. One thing I noticed is that the first time you switch to each different size, the background container (with the image block icon and light gray background) is displayed at full size for a split second. Video for reference: https://cloudup.com/c642ckhMCez |
@iamthomasbishop The improvements from this fix should make this much less jarring, especially in dark mode. |
Moved milestone to v1.22. |
c35ad56
to
9a23135
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
closing as gutenberg changes were brought in to gb-mobile through another PR (still under DEV flag). See this PR for removing DEV flag and updating release notes for this feature: #1904 |
Fixes #1452
Companion PR's
Gutenberg PR: WordPress/gutenberg#19232
WPiOS PR (for testing): wordpress-mobile/WordPress-iOS#13052
Changes
Screenshots
See this comment and above comments for context: WordPress/gutenberg#17245 (review)
To Test:
*Note this PR is mainly covering UI updates, for Image Size error handling with updating URL's from the network etc, see this issue: #1593
Update release notes:
RELEASE-NOTES.txt
.