Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only report selection changes if text view is still first responder. #1374

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Only report selection changes if text view is still first responder. #1374

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc8eb7d
Only report selection changes if text view is still first responder.
SergioEstevao Sep 20, 2019
e930453
Join two guards.
SergioEstevao Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,9 @@ class RCTAztecView: Aztec.TextView {
extension RCTAztecView: UITextViewDelegate {

func textViewDidChangeSelection(_ textView: UITextView) {
guard isFirstResponder else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add this statement to the previously existing guard?
Not sure if we get an advantage by having them separated.

return
}
guard isInsertingDictationResult == false else {
return
}
Expand Down