-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix store crash with gutenberg master #1366
Merged
Merged
Changes from 8 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
e2defe5
Fix store crash with gutenberg master
Tug 4433387
Update gutenberg ref
Tug a652ccc
Update gutenberg ref
Tug 8ab38d5
Remove unused require
Tug fb33f0c
Fix tests
Tug d0cc756
Merge remote-tracking branch 'origin/develop' into update/fix-store-c…
Tug 8c2c477
Add missing @wordpress/block-directory package in symlinked-packages
Tug 08caa7c
Update gutenberg ref
Tug 1e0ad56
Use real timers for e2e tests
Tug 97da943
Use fake timers in unit tests not config
Tug 03cc901
Update gutenberg ref
Tug 47ed605
Update gutenberg ref
Tug 042ee2b
Merge remote-tracking branch 'origin/develop' into update/fix-store-c…
Tug 79009b1
Add comment explaining why we need to call jest.runAllTicks();
Tug 69c339d
Merge remote-tracking branch 'origin/develop' into update/fix-store-c…
Tug b651fbe
Update gutenberg ref
Tug e7e7b7b
Merge remote-tracking branch 'origin/develop' into update/fix-store-c…
Tug 20a565c
Increase the number of workers so tests don't get queued when calling…
Tug 3b5577f
Reenable disabled e2e tests
Tug 6c75768
Reenable disabled e2e tests
Tug 8c9f4cb
Update gutenberg ref
Tug 81168f5
Update gutenberg ref
Tug fb6db57
Disable warning notices
Tug 561f27e
Disable warning notices, fix lint
Tug 078e62d
Merge remote-tracking branch 'origin/develop' into update/fix-store-c…
Tug 0081ee8
Update gutenberg ref
Tug be87adf
Revert max workers to 3 and increase timeout in tests for now
Tug b55f55d
Update gutenberg ref
Tug File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../gutenberg/packages/block-directory/src |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting!
Can we add a comment saying why/when is this needed? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one here for the same reason.
It seems that when
EDIT_ENTITY_RECORD
is dispatched using this generator function it's done so asynchronously, meaning the promise does not resolve immediately even during tests.Which makes
resetEditorBlocks
async which meanssetupEditorState
which comes right after is delayed which meansisReady
will betrue
after some time which meanseditorDidMount
will also be called after some time.This is related to the changes made on core data entities so I figured it was safe to update our tests for now. I'll try to find a good explanation for this and add something 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very inconvenient to enforce running fake timers but I guess this is what it is. I don't think we use unit tests to test the root component for the web code.