Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard hide button #1321

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Aug 22, 2019

Fixes #952

Full description of the fix is in the description of the related Gutenberg PR.

Update release notes:

There aren't any user-facing changes

@pinarol
Copy link
Contributor

pinarol commented Aug 23, 2019

Thanks for the gutenberg-mobile PR. This is looking good but let's not merge this one yet since it is brining another gutenberg PR that makes the editor crash.

Screen Shot 2019-08-23 at 12 02 32

@pinarol pinarol self-requested a review August 23, 2019 11:40
@pinarol pinarol added [Type] Bug Something isn't working bugfix and removed [Type] Bug Something isn't working labels Aug 23, 2019
@pinarol pinarol added this to the 1.12 milestone Aug 23, 2019
@pinarol
Copy link
Contributor

pinarol commented Aug 30, 2019

Associated gutenberg PR is merged. Could you update gutenberg subrepo to point to rnmobile/master?

@pinarol
Copy link
Contributor

pinarol commented Aug 30, 2019

I think CI is failing because it can't checkout submodule react-native-aztec, it looks like you'll either need to fork react-native-aztec too or open the PR within gutenberg-mobile repo directly, I gave you access in gutenberg-mobile repo, you should be able to do that.

@geriux
Copy link
Contributor Author

geriux commented Aug 30, 2019

On it! Was waiting to see if I got the other one right. Thanks!

@geriux
Copy link
Contributor Author

geriux commented Aug 30, 2019

Closing, new PR here #1340

@etoledom
Copy link
Contributor

etoledom commented Oct 2, 2019

Closing, new PR here #1340

Closing by @geriux comment

@etoledom etoledom closed this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS]Keyboard hide button is not working on post title
3 participants