-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that OS-level font-size settings are honored in editor #605
Comments
@iamthomasbishop Right now I'm investigating the issue and let me confirm that this is the issue only for iOS or both iOS/Android🙇I built WP-iOS/Android app with the latest commit hash on develop branch and what I saw is the following. iOSAfter changing system level font size I could reproduce the issue. AndroidAfter changing system level font size I could not reproduce the issue. So right now I'm wondering this is the only issue for iOS..am I missing something?🙇Thank you! |
👋 @hotchemi , judging from the gif you shared, I think that the editor there is Aztec, not Gutenberg. Have you perhaps tried Gutenberg too and the font sizing issue doesn't happen? |
@hypest Thank you for pointing out🙇I tried again on Android and found gutenberg-mobile and wp-android behave slightly differently. gutenberg-mobileOn example app it seems works. wp-androidI could repricate the issue. |
@etoledom Thank you for clarification! After investigation turned out situation is a bit involved..😅
This is another issue and after dismissing the red screen seems fontSize is changed properly on gutenberg-mobile example app. |
Android side PR: wordpress-mobile/WordPress-Android#9509 |
So I tested this on WP-iOS and found the following:
Here are some screenshots: |
Ouch, that doesn't look good 😬
This is probably because Attributed text? 🤔
It's interesting that these blocks are also x-platform blocks. Do we have a default static font size for Aztec? |
Following WordPress/gutenberg#57339, initial support for Dynamic Type will be introduced in 24.0 on iOS, due to be rolled out to users on January 22nd. I can verify that support for OS-level font-size changes is already there for Android. I've also created a task list at WordPress/gutenberg#57354 to follow up on enhancements, including enforcing a max/min size, refactoring RichText to automatically update, and reviewing other areas of the editor. I'll close this specific issue as we now have initial support and will track iterations elsewhere. 🙇♀️ |
While inspecting tablet layout refinements here, I noticed that changes to font-size on the OS level aren't honored in the editor – both on iOS and Android.
Steps to reproduce
The text was updated successfully, but these errors were encountered: