Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Improve editor's adaptability to device font size changes #57354

Open
3 tasks
SiobhyB opened this issue Dec 22, 2023 · 0 comments
Open
3 tasks

[RNMobile] Improve editor's adaptability to device font size changes #57354

SiobhyB opened this issue Dec 22, 2023 · 0 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@SiobhyB
Copy link
Contributor

SiobhyB commented Dec 22, 2023

Description

Following support for Dynamic Type on iOS in #57339, there are more opportunities for improving how the editor adapts to font size changes made via a device's accessibility settings.

  • Enforce a maximum and minimum display font size, to account for cases where users may set very small or large custom font sizes.
  • Refactor so that RichText blocks adapt to updates to the Dynamic Type setting without a need to close and re-open the block editor.
  • Review other areas of the editor for improvements.

Relevant notes/issues:

Step-by-step reproduction instructions

  • On iOS, navigate to the Accessibility section in the Settings app.
  • Select Display & Text Size then toggle Larger Accessibility Sizes to on.
  • Select a larger accessibility size.
  • Open the WordPress app and navigate to the post or page editor.
  • Navigate through some everyday writing flows.

Expected behaviour

For text to always be clear and legible, and not to collide or overflow UI.

Actual behaviour

There are some places where text is bigger than its container or where it can even be illegible, such as #37995.

Device information

  • Device: iPhone XR
  • WordPress app version: 23.8.1
@SiobhyB SiobhyB added [Type] Task Issues or PRs that have been broken down into an individual action to take [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Dec 22, 2023
@SiobhyB SiobhyB added the [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. label Dec 22, 2023
@twstokes twstokes removed the [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

2 participants