Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Justify" to text-alignment options on blocks that support text-alignment - Jetpack/WordPress.com only #575

Open
iamthomasbishop opened this issue Feb 7, 2019 · 18 comments
Labels
Proposal [Type] Enhancement Improves a current area of the editor

Comments

@iamthomasbishop
Copy link
Contributor

The title basically says it all. Worth noting that this would initially be beneficial on Paragraph and Heading Blocks as we start adding text-alignment options.

Icon options, depending on if we end up using Dashicons or Material:

Related proposal on Core (not final at the time of this posting): Automattic/wp-calypso#28696

@SergioEstevao
Copy link
Contributor

@iamthomasbishop we don't support justify on the web is this something we want to do for mobile-only?

@iamthomasbishop
Copy link
Contributor Author

we don't support justify on the web is this something we want to do for mobile-only?

It's supported on WordPress.com (and it's broken, from the looks of it 😬), but since it's not supported in Core Gutenberg, we can probably close this one for now.

@maxme
Copy link
Contributor

maxme commented May 7, 2020

Note: we had a review on the Play Store from someone who wants "Justify" back (both on the Web and Mobile).

@designsimply
Copy link
Contributor

Noting another Play Store review requesting the option to justify text.

Tiraram a ferramenta de justificar os textos, ficou péssimo! Arrumem isso! Essa nova atualização só faz a gente passar raiva!

Translated with http://translate.google.com/

They took the tool to justify the texts, it was terrible! Fix it! This new update only makes us angry!

1-star app review by Danny feeer – May 26, 2020 - WPiOS 14.8.2 - Brazil

@maxme
Copy link
Contributor

maxme commented May 28, 2020

@SergioEstevao @iamthomasbishop - I think we should reopen that one, even if we make it a Jetpack-only feature (since it's not supported in core).

@iamthomasbishop
Copy link
Contributor Author

@maxme Is the underline capability enabled via Jetpack or is it a third-party plugin on WordPress.com that makes it available?

@SergioEstevao
Copy link
Contributor

SergioEstevao commented Jun 2, 2020 via email

@iamthomasbishop
Copy link
Contributor Author

@SergioEstevao I meant to say justify, not underline — my bad. My question is where is justify enabled? Sorry for the confusion.

@SergioEstevao
Copy link
Contributor

SergioEstevao commented Jun 2, 2020 via email

@maxme
Copy link
Contributor

maxme commented Jun 3, 2020

Is the justify capability enabled via Jetpack or is it a third-party plugin on WordPress.com that makes it available?

I see the option there https://wordpress.org/gutenberg/ and I see it on simple and Atomic sites (I disabled all plugins but Jetpack), but I don't see it on a non-atomtic Jetpack site. I guess it's a layer added from wpcom.

Screenshot 2020-06-03 at 13 31 35

@iamthomasbishop
Copy link
Contributor Author

I see the option there https://wordpress.org/gutenberg/

I guess it's a layer added from wpcom.

If it's on the GB demo wouldn't it be coming from core GB? I don't remember seeing justify on core when we first investigated, so maybe that's been added relatively recently. If this is the case, we can probably safely add it justify to the toolbar, although we might want to tuck it behind a similar dropdown/menu. We were recently talking about how we might consolidate inline text style options, so maybe now is the time to do this.

Also worth noting that justify doesn't work properly on the demo (nor on wpcom — tried both Chrome and Safari on Mac) 😬

@designsimply
Copy link
Contributor

designsimply commented Jun 13, 2020

Justified text was removed from WordPress in version 4.7 for accessibility reasons. Announcement: https://make.wordpress.org/core/2016/10/28/editor-changes-in-4-7/. Related article: http://mediaaccess.org.au/accessibledocumentservice/2015/08/text-justification-is-a-key-accessibility-issue-in-documents/.

Text justification was added to WordPress.com Gutenframe on Mar 29 2019 (D26137) and to Jetpack/Atomic on Apr 25 2019 (Automattic/jetpack#12070) due to popular demand (wp-calypso/28696).

Still, there are many requests for the option to justify text in core Gutenberg but the decision to remove the option still stands as of today.

I am in favor of supporting the option at least for WordPress.com and Jetpack because it is supported on the web for those types of sites and because it is a popular request—it's odd to me that this feedback isn't being communicated well because I know for sure that it does come up!

Here is another recent example from an app review:

They could include the "justify" option in the application. There are people, like me, who like to keep the text straight on the sides.

3-star app review by Gabriel Carnioli - 6/12, 1:42 PM - Samsung Galaxy A50 Android 10

@maxme
Copy link
Contributor

maxme commented Jun 15, 2020

We were recently talking about how we might consolidate inline text style options, so maybe now is the time to do this.

Ok, let's work on that (added a project to our timeline), we should think of an extensible design that allows us to add more options.

Thanks @designsimply for the history on that feature. And I agree that we should at least add it for Jetpack and WordPress.com sites.

@maxme maxme reopened this Jun 15, 2020
@maxme maxme changed the title Proposal: Add "Justify" to text-alignment options on blocks that support text-alignment Add "Justify" to text-alignment options on blocks that support text-alignment - Jetpack/WordPress.com only Jun 15, 2020
@designsimply
Copy link
Contributor

I found another app review asking for text justification.

When designing my entry, things for me as fundamental as the justifier of the text because it does not appear then I prefer to continue editing in a different way on a PC although it bothers me because the one of immediacy of the place where I am living the event or the event that inspires me.

Auto-translated from Spanish:

A la hora de maquetar mi entrada cosas para mi tan fundamentales como el justificador del texto pues no aparece entonces prefiero seguir editando de otra manera en un PC aunque me suponga una molestia por no poder hacerlo el de inmediatez del lugar donde esté viviendo el hecho o el acontecimiento que me inspire.

2-star app review by Anye M - 6/28 3:35 - LG G6 Android 9

@designsimply
Copy link
Contributor

Why there is no paragraph justification?

4-star app review by Bayisa Guta Aug 6, 2020 at 2:48 PM - PhonePad3 WPAndroid 15.2.1 Android 6.0

@designsimply
Copy link
Contributor

I found another App Review which asks for text justification:

Provide option for justification.

3-star app review - May 11, 2020 - WPiOS 14.7 - India

@designsimply
Copy link
Contributor

Another app review from the past mentioned not being able to justify text (I sent them an update letting them know the other alignment options should be available).

When writing a post, there isn’t an option for the following:

Align text left - normal option
Align text right - the opposite of the above
Centre text - have text in the centre of the page
Or Justify - basically a combination of align text left and right.

3-star App Review - WPiOS 15.5 - Aug 28, 2020

@reginabally
Copy link

I don't understand why there is no option to format justified in the app. Every time I have to go to the browser and format all the text created with the app ...

Platform: Google Play Store
Date of review: Jan 15, 2021, 23:29
App version name: 16.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposal [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

No branches or pull requests

5 participants