-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure an empty draft can't be published #369
Make sure an empty draft can't be published #369
Comments
Hmm, interesting. We'll need to figure out a way to mask out the change introduced by the empty GB paragraph block. The block does sport the GB delimiters and an empty |
I hadn't noticed that detail. I'm seeing the same thing both on iOS and Android: when you tap to create a new block, it will have some HTML even if there is no text in it. The post will look empty but it won't have empty content. That first part can go to the beta, we probably need to treat a post with an unmodified block as an empty post, but that's OK for the alpha. I'd still like to address the second part if it's a quick fix. |
Are you sure that Aztec already behaves that way? I just tried to publish and empty post with Aztec on Android, and the |
Interesting, it does on iOS. Let's do it on iOS for the Alpha, since I imagine it'd be easy, and consider the Android part for the beta |
The problem is that we need to send a signal from JS to Native for every time the post content changes. In that way our This means that we will need to serialize to HTML on every key stroke or action that modifies the content. Probably we will have to do something of the sort at some point anyway. We could simplify it to send a signal if the content became I can give it a look to be sure about the difficulties, but I believe it is not an easy/quick fix. |
OK, thanks for the explanation, let's move it to the Beta then |
This is actually two separate issues. For the beta let's at least figure out what's not working correctly and re-evaluate. |
Verified the issue still happening on WPiOS 15.0. On WPAndroid (alpha-228) the empty post is not saved as a draft when you exit the editor (by pressing "Back"), and hitting "Publish" shows a Toast with "Can't publish an empty post", both of which are not an issue. I will change this ticket to "iOS" only, mark is as "Writing flow" and assign it to the Releases&Maintenance squad. |
As reported by @rachelmcr:
I’m able to save a completely empty post (no title or content). That shouldn’t be possible. To reproduce:
You can also try to publish an empty post, although it fails. The “Publish” button shouldn’t be enabled in that case:
I'm adding this one for the alpha assuming it's a quick fix, since Aztec already behaves that way.
The text was updated successfully, but these errors were encountered: