Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Shortcode block cuts off multiline task #1868

Closed
chipsnyder opened this issue Feb 7, 2020 · 1 comment · Fixed by WordPress/gutenberg#20097 or #1872
Closed

[Android] Shortcode block cuts off multiline task #1868

chipsnyder opened this issue Feb 7, 2020 · 1 comment · Fixed by WordPress/gutenberg#20097 or #1872
Assignees

Comments

@chipsnyder
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Page or post
  2. Add a shortcode block
  3. type a multiline shortcode
  4. See error

Expected behavior
TextInput should grow with its content.

Screenshots
textCutoff

Smartphone (please complete the following information):

  • Device: Pixel 3a
  • OS: Android X
  • Version 28, 29

Additional context
This issue was introduced as a part of #1808 specifically for the workaround here https://github.com/WordPress/gutenberg/pull/19848/files#diff-7232ee72926f10a0aad2ee0c3bfb6612R46

@chipsnyder
Copy link
Contributor Author

Chatting with @maxme, we're going to remove the workaround we put in place here: https://github.com/WordPress/gutenberg/pull/19848/files#diff-7232ee72926f10a0aad2ee0c3bfb6612R41-R46

While investigating this issue, we found it also causes issues by not respecting the text break setting:

screenshot-1581078787522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant