Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile]Fix layout issue in Shortcode #20097

Merged
merged 2 commits into from
Feb 10, 2020

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Feb 7, 2020

Description

Removed a workaround introduced by #19848 The original change was put in place due to a React Native bug. Manufacturers don't universally honor the flags to hide the autocomplete toolbar with autocomplete disabled. For example, Google devices running API 26 and below will honor the flag, where devices running API 27 and above won't.

Fixes: wordpress-mobile/gutenberg-mobile#1868
Related PR's
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#1872

How has this been tested?

1.) Select a shortcode block
2.) Type enough text to wrap to a second line or more

Expect:

  • Text input to grow with content
  • The device should not automatically force an autosuggest change.
  • Some devices/APIs won't show the prompt at all.

3.) Delete text
Expect:

  • Text input to shrink with content

4.) Paste content
Expect:

  • Text input to grow with content
  • The text should have similar wrapping as a prefilled block.

Screenshots

screenshot-1581089540744

Types of changes

Fixes: wordpress-mobile/gutenberg-mobile#1868

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@chipsnyder chipsnyder added the [Type] Bug An existing feature does not function as intended label Feb 7, 2020
@chipsnyder chipsnyder requested a review from geriux February 7, 2020 15:36
Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested following the cases in the description 🎉

@chipsnyder chipsnyder modified the milestones: Future, Gutenberg 7.5 Feb 10, 2020
@chipsnyder chipsnyder merged commit 1503a07 into master Feb 10, 2020
@chipsnyder chipsnyder deleted the rnmobile/issue-1868-textcutoff branch February 10, 2020 19:54
@youknowriad youknowriad modified the milestones: Future, Gutenberg 7.6 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Shortcode block cuts off multiline task
3 participants