-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links: “Open in a new tab” setting doesn’t look like it saves. #1161
Comments
I thought this was fixed recently (#1018 ?), but maybe we've got a regression on our hands. |
I think it's not a problem with the link setting itself, but a problem with the underlying selection data. The system seems to be confused about what is the text selected. |
@etoledom agreed - when I carefully place the cursor mid-word, I could see the link. When the whole word was selected, I'd see no link. |
I'm no longer able to reproduce this issue, so going ahead to close this one. :) |
Expected:
When I set the “Open in a new tab” setting for a link, I expect it to remain toggled on.
Actual:
It does not remain toggled on in all circumstances, even though the target=“_blank” remains in tact.
This happens in Paragraph
To Reproduce:
This makes it very difficult to know for sure whether I have in fact set the link to “Open in a new tab”.
Video:
However, the target=“_blank” remains in tact despite it not appearing consistently.
This has to be tested in a web browser, since currently preview posts in iOS opens them in the in-app browser. When we tap the link, the device browser opens, so there’s not a simple way to tell whether it was set to open in a new tab or not without browser tools.
In a browser, we can easily Inspect Element, or simply test the link when previewing.
To Reproduce:
iPhone SE, (iOS 12.2) running WPiOS 12.7
The text was updated successfully, but these errors were encountered: