Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links: Undo doesn’t work for links that open in a new tab. #1160

Closed
thehenrybyrd opened this issue Jun 19, 2019 · 3 comments
Closed

Links: Undo doesn’t work for links that open in a new tab. #1160

thehenrybyrd opened this issue Jun 19, 2019 · 3 comments
Labels
[Type] Bug Something isn't working

Comments

@thehenrybyrd
Copy link

Expected:
After adding any link, tapping “Undo” would undo the addition of the link.

Actual:
After adding a link which is set to “open in a new tap”, the Undo button does nothing and Redo button is greyed out.

Works in Paragraph, Header, List, Quote blocks.

To reproduce:

  1. Create a new post
  2. Add a paragraph block, type some text.
  3. Add a link and set it to “Open in a new tab”.
  4. Tap Undo and find it does nothing.

Video:
quoteblocklink

Tested on iPhone SE, (iOS 12.2) running WPiOS 12.7

@hypest hypest added the [Type] Bug Something isn't working label Jul 8, 2019
@hypest
Copy link
Contributor

hypest commented Jul 22, 2019

This seems related to #1161, especially if that one is about state not being set correctly.

@designsimply
Copy link
Contributor

Closed #2495 as a duplicate and adding some additional notes from that issue. /hat tip @mchowning

Observe that no matter how many times you slowly tap the undo button, the link remains. If you tap the undo button a bunch of times very quickly, however, it is possible to remove the link.

Additional context
I wonder if there might be some connection between this and #2091

@SiobhyB
Copy link
Contributor

SiobhyB commented Nov 16, 2023

Tested and confirmed undo now works as expected in this scenario, I believe it was fixed as part of WordPress/gutenberg#50460.

@SiobhyB SiobhyB closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants