Merge pull request #1667 from wordpress-mobile/release/1.19.0

Release v1.19.0

.circleci/config.yml

@@ -91,7 +91,7 @@ jobs:
           path: ./reports/test-results
   ios-device-checks:
     macos:
-      xcode: "10.2.0"
+      xcode: "11.2.1"
     steps:
     - checkout
     - checkout-gutenberg

RELEASE-NOTES.txt

@@ -1,3 +1,11 @@
+1.19.0
+------
+* Add support for changing Settings in List Block.
+* [iOS] Fix crash dismissing bottom-sheet after device rotation.
+* [Android] Add support for Preformatted block.
+* New block: Gallery. You can now create image galleries using WordPress Media library. Upload feature is coming soon.
+* Add support for Video block settings
+
 1.18.0
 ------
 * [iOS] Added native fullscreen preview when clicking image from Image Block

__device-tests__/gutenberg-editor-block-insertion.test.js

@@ -11,6 +11,7 @@ import {
 	isLocalEnvironment,
 	stopDriver,
 	isAndroid,
+	swipeDown,
 	clickMiddleOfElement,
 } from './helpers/utils';
 import testData from './helpers/test-data';
@@ -39,6 +40,7 @@ describe( 'Gutenberg Editor tests for Block insertion', () => {
 	} );
 
 	it( 'should be able to see visual editor', async () => {
+		// wait for the block editor to load
 		await expect( editorPage.getBlockList() ).resolves.toBe( true );
 	} );
 
@@ -100,6 +102,7 @@ describe( 'Gutenberg Editor tests for Block insertion', () => {
 			await editorPage.dismissKeyboard();
 		}
 
+		await swipeDown( driver );
 		const titleElement = await editorPage.getTitleElement( { autoscroll: true } );
 		await titleElement.click();
 		await titleElement.click();

__device-tests__/helpers/caps.js

@@ -1,12 +1,12 @@
-exports.ios12 = {
+exports.ios = {
 	browserName: '',
 	platformName: 'iOS',
-	platformVersion: '12.2',
-	deviceName: 'iPhone Simulator',
+	platformVersion: '13.0',
+	deviceName: 'iPhone 11 Simulator',
 	os: 'iOS',
 	deviceOrientation: 'portrait',
 	automationName: 'XCUITest',
-	appiumVersion: '1.13.0', // SauceLabs requires appiumVersion to be specified.
+	appiumVersion: '1.15.0', // SauceLabs requires appiumVersion to be specified.
 	app: undefined, // will be set later, locally this is relative to root of project
 };
 
@@ -20,6 +20,6 @@ exports.android8 = {
 	appPackage: 'com.gutenberg',
 	appActivity: 'com.gutenberg.MainActivity',
 	deviceOrientation: 'portrait',
-	appiumVersion: '1.13.0',
+	appiumVersion: '1.15.0',
 	app: undefined,
 };

__device-tests__/helpers/utils.js

@@ -15,7 +15,7 @@ import path from 'path';
  * Internal dependencies
  */
 import serverConfigs from './serverConfigs';
-import { ios12, android8 } from './caps';
+import { ios, android8 } from './caps';
 import AppiumLocal from './appium-local';
 import _ from 'underscore';
 
@@ -64,7 +64,7 @@ const setupDriver = async () => {
 		} catch ( err ) {
 			// Ignore error here, Appium is probably already running (Appium desktop has its own server for instance)
 			// eslint-disable-next-line no-console
-			console.log( 'Could not start Appium server', err.toString() );
+			await console.log( 'Could not start Appium server', err.toString() );
 		}
 	}
 
@@ -92,9 +92,11 @@ const setupDriver = async () => {
 			desiredCaps.app = `sauce-storage:Gutenberg-${ safeBranchName }.apk`; // App should be preloaded to sauce storage, this can also be a URL
 		}
 	} else {
-		desiredCaps = _.clone( ios12 );
+		desiredCaps = _.clone( ios );
 		if ( isLocalEnvironment() ) {
 			desiredCaps.app = path.resolve( localIOSAppPath );
+			delete desiredCaps.platformVersion;
+			desiredCaps.deviceName = 'iPhone 11';
 		} else {
 			desiredCaps.app = `sauce-storage:Gutenberg-${ safeBranchName }.app.zip`; // App should be preloaded to sauce storage, this can also be a URL
 		}

__device-tests__/pages/editor-page.js

@@ -40,7 +40,7 @@ export default class EditorPage {
 	}
 
 	async getBlockList() {
-		return this.driver.hasElementByAccessibilityId( 'block-list' );
+		return await this.driver.hasElementByAccessibilityId( 'block-list' );
 	}
 
 	// Finds the wd element for new block that was added and sets the element attribute

android/app/build.gradle

@@ -145,6 +145,7 @@ repositories {
 
 
 dependencies {
+    implementation project(':@react-native-community_slider')
     implementation project(':react-native-video')
     implementation project(':react-native-svg')
     implementation project(':react-native-aztec')

android/app/src/main/java/com/gutenberg/MainApplication.java

@@ -6,6 +6,7 @@
 import androidx.core.util.Consumer;
 
 import com.facebook.react.ReactApplication;
+import com.reactnativecommunity.slider.ReactSliderPackage;
 import com.brentvatne.react.ReactVideoPackage;
 import com.facebook.react.bridge.ReadableArray;
 import com.facebook.react.devsupport.interfaces.DevOptionHandler;
@@ -126,6 +127,7 @@ public boolean getUseDeveloperSupport() {
             protected List<ReactPackage> getPackages() {
                 return Arrays.asList(
                         new MainReactPackage(),
+                        new ReactSliderPackage(),
                         new ReactVideoPackage(),
                         new SvgPackage(),
                         new ReactAztecPackage(),

android/settings.gradle

@@ -1,4 +1,6 @@
 rootProject.name = 'gutenberg'
+include ':@react-native-community_slider'
+project(':@react-native-community_slider').projectDir = new File(rootProject.projectDir, '../node_modules/@react-native-community/slider/src/android')
 include ':react-native-video'
 project(':react-native-video').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-video/android-exoplayer')
 include ':react-native-svg'

babel.config.js

@@ -26,7 +26,7 @@ module.exports = function( api ) {
 						},
 					],
 				],
-				exclude: /node_modules\/react-native/,
+				exclude: /node_modules\/(react-native|@react-native-community)/,
 			},
 			{
 				// Auto-add `import { createElement } from '@wordpress/element';` when JSX is found
@@ -41,7 +41,7 @@ module.exports = function( api ) {
 						},
 					],
 				],
-				exclude: /node_modules\/react-native/,
+				exclude: /node_modules\/(react-native|@react-native-community)/,
 			},
 		],
 		env: {