Skip to content

Commit

Permalink
Merge pull request #2469 from wordpress-mobile/issue/improve_release_…
Browse files Browse the repository at this point in the history
…script

Improve release script
  • Loading branch information
SergioEstevao authored Jul 16, 2020
2 parents 7443b1a + 047edc9 commit 0d48583
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
14 changes: 7 additions & 7 deletions .github/PULL_REQUEST_TEMPLATE/release_pull_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ Release for Gutenberg Mobile v1.XX.Y

## Release Submission Checklist

- [ ] Release number was bumped
- [ ] Aztec dependencies are pointing to a stable release
- iOS: 'grep WordPressAztec-iOS RNTAztecView.podspec'
- Android: 'grep aztecVersion react-native-aztec/android/build.gradle'
- [ ] Gutenberg 'Podfile' and 'Podfile.lock' inside './ios/' are updated to the release number
- [ ] Bundle package of the release is updated
- [ ] Check if `RELEASE-NOTES.txt` is updated with all the changes that made it to the release
- [ ] Release number was bumped.
- [ ] Aztec dependencies are pointing to a stable release.
- iOS: 'grep WordPressAztec-iOS RNTAztecView.podspec'.
- Android: 'grep aztecVersion react-native-aztec/android/build.gradle'.
- [ ] Gutenberg 'Podfile' and 'Podfile.lock' inside './gutenberg/packages/react-native-editor/ios/' are updated to the release number and do not point to any development pods.
- [ ] Bundle package of the release is updated .
- [ ] Check if `RELEASE-NOTES.txt` and `gutenberg/packages/react-native-editor/RELEASE-NOTES.txt` are updated with all the changes that made it to the release.

6 changes: 3 additions & 3 deletions bin/release_automation.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ npx json -I -f package.json -e "this.version='$VERSION_NUMBER'" || { echo "Error
# Set version number in react-native-editor package.json
npx json -I -f gutenberg/packages/react-native-editor/package.json -e "this.version='$VERSION_NUMBER'" || { echo "Error: could not update version in react-native-editor package.json"; exit 1; }

# Make sure podfile is updated
npm run core preios

# Commit react-native-editor package changes
cd gutenberg
git commit -a -m "Update react-native-editor version to: $VERSION_NUMBER" || { echo "Error: failed to commit changes"; exit 1; }
Expand All @@ -56,9 +59,6 @@ cd ..
# Commit package version update changes
git commit -a -m "Update gb mobile version to: $VERSION_NUMBER" || { echo "Error: failed to commit changes"; exit 1; }

# Make sure podfile is updated
npm run core preios

# Update the bundles
npm run bundle || { printf "\nError: 'npm bundle' failed.\nIf there is an error stating something like \"Command 'bundle' unrecognized.\" above, perhaps try running 'rm -rf node_modules gutenberg/node_modules && npm install'.\n"; exit 1; }

Expand Down

0 comments on commit 0d48583

Please sign in to comment.