Gravatar SDK integration #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/WordPress-iOS#22543
WordPress-iOS PR: wordpress-mobile/WordPress-iOS#22921
Deprecates some types in favor of the new Gravatar iOS SDK
Makes
listenForGravatarChanges()publicA side note: It's extra important to remove the "Gravatar" struct for us in the future because it causes a name conflict with the new Gravatar module and leads to various import problems. For example when we import WordPressUI and Gravatar at the same time and try to call a Gravatar type like
Gravatar.SomeTypethe compiler will get confused and throw an error as if we are trying to refer to theWordPressUI.Gravatarstruct instead.CHANGELOG.mdif necessary.