Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gravatar SDK to download the image via URL #143

Merged

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Feb 16, 2024

Use Gravatar SDK to download the image via URL.

Changing the implementation of our new method

public func downloadGravatar(_ gravatar: GravatarURL?, placeholder: UIImage, animate: Bool, failure: ((Error?) -> ())? = nil) 

Test:

Impacted files in the WP repo:

  • ListTableViewCell
  • CommentContentTableViewCell
  • NoteBlockCommentTableViewCell
  • NoteBlockHeaderTableViewCell
  • NoteBlockUserTableViewCell
  • PeopleCell
  • PersonViewController
  • RevisionsTableViewCell
    NotificationContentView (I haven't figured how we can test this yet.)

Documentation of testing steps can be found here: wordpress-mobile/WordPress-iOS#22543 (comment) Please take a look and see if you can find anything odd. For now the avatars should be loading successfully.


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@pinarol pinarol requested a review from etoledom February 16, 2024 12:49
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Tested all paths in the same what than in wordpress-mobile/WordPress-iOS#22624 (review)

All smoke tests look good.

I did find something interesting which seem to come from the previous integration (not related to this PR).

In the notifications view, under low connectivity conditions, is visible when the reused cell has the previous image set, while the new image is loading:

CleanShot 2024-02-16 at 14 37 44

I'm highlighting this as documentation, to let the WPiOS team know about this in case they would like to do something about it.

:shipit: 🎉

@pinarol pinarol merged commit 0f24b42 into task/gravatar-integration Feb 16, 2024
2 of 5 checks passed
@pinarol pinarol deleted the wppinar/gravatar-image-download-via-sdk-1 branch February 16, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants