Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sending magic links to inexistent accounts #822

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Nov 14, 2024

Description

Part of woocommerce/woocommerce-ios#14419

This PR updates the magic link request with an option to pass the option create_account, this option allows to use the same request for signup flow needed for the above task.

Testing Details

Use woocommerce/woocommerce-ios#14431


  • Please check here if your pull request includes additional test coverage.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

Copy link

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time reviewing Obj C so bear with me if anything's missing. But from what I can tell the logic is pretty sound here.

@hichamboushaba hichamboushaba merged commit a005f59 into trunk Nov 20, 2024
10 checks passed
@hichamboushaba hichamboushaba deleted the magic-link-create-account branch November 20, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants