Remove usages of GetData
#747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guarani
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Looks good! I confirmed that feature announcements work and the Zendesk code was able to fetch my site's plan.
Thanks @crazytonyli!
|
Merging as requested here: p1709860929336219/1709766129.730749-slack-C04PWEZSYFL @mokagio, this one does not need to be included in the 24.4 beta. |
crazytonyli
added a commit
to wordpress-mobile/WordPress-iOS
that referenced
this pull request
Mar 8, 2024
Including a bug fix to getting feature announcement and zendesk metadata. See wordpress-mobile/WordPressKit-iOS#746 and wordpress-mobile/WordPressKit-iOS#747. See the full 14.0.0 - 14.0.1 changes [here][diff]. [diff]: wordpress-mobile/WordPressKit-iOS@14.0.0...14.0.1
crazytonyli
added a commit
to wordpress-mobile/WordPress-iOS
that referenced
this pull request
Mar 8, 2024
Including a bug fix to getting feature announcement and zendesk metadata. See wordpress-mobile/WordPressKit-iOS#746 and wordpress-mobile/WordPressKit-iOS#747. See the full 14.0.0 - 14.0.1 changes [here][diff]. [diff]: wordpress-mobile/WordPressKit-iOS@14.0.0...14.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is built on top of #746.
This PR removes a couple of usages of
GetDataand usesWordPressComRestApi's decodingDecodableAPI.Testing Details
The changes are covered by the new unit tests in #746.
CHANGELOG.mdif necessary.