Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Global Styles endpoint to support non-experimental paths #416

Merged
merged 7 commits into from
Jul 14, 2021

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Jul 7, 2021

Description

This updates the Global styles endpoint to use the non-experimental paths for fetching the block editor settings.

Testing Details

This can be tested with the same notes in: wordpress-mobile/WordPress-iOS#16823

  • Please check here if your pull request includes additional test coverage.

@chipsnyder chipsnyder force-pushed the gutenberg/gss/endpoint_update branch from eab8946 to cc6836f Compare July 9, 2021 18:05
@chipsnyder chipsnyder marked this pull request as ready for review July 9, 2021 20:01
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @chipsnyder 👍
Tested this with wordpress-mobile/WordPress-iOS#16823 and everything works as expected. The code changes and tests looks great too 🎉

@chipsnyder chipsnyder merged commit d189099 into develop Jul 14, 2021
@chipsnyder chipsnyder deleted the gutenberg/gss/endpoint_update branch July 14, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants