Added signup_flow_name attribute #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to account creation with email
|
@leandroalonso , updated and ready for another look |
leandroalonso
requested changes
Oct 18, 2019
|
@leandroalonso , thanks for this review. Updated accordingly and ready for another look. I checked the requests body for both login and signup in charles proxy and the new parameter is added to signup and not login.
|
leandroalonso
approved these changes
Oct 21, 2019
|
@yaelirub Works as expected. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to account creation with email
Description
wordpress-mobile/WordPress-iOS#12724
To test:
in WPiOS update WordPressKit pod to:
pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :branch => 'task/add_signup_attribute'and test signup with email works
Seems like
createWPComAccountWithEmailis not being used anymore (which is where I originally added the param. I created an issue to remove this method : #191