-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for requesting account creation when sending auth magic link #861
Conversation
bac645f
to
ab26abe
Compare
ab26abe
to
e952ebf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good as it's simply getting the latest change from WordPressKit and using the new function from there.
I took over this PR fix the WordPressKit dependency wiring. I've enabled auto merge and will proceed to update WooCommerce to point to these changes once they land. |
Part of: woocommerce/woocommerce-ios#14419
This PR adds support for requesting the creation of the account when using
WordPressComAccountService/requestAuthenticationLink
, this allows using the same WPCom endpoint for sending magic link to both existing and new accounts.Testing
Check woocommerce/woocommerce-ios#14431
CHANGELOG.md
if necessary.