Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for requesting account creation when sending auth magic link #861

Merged
merged 8 commits into from
Nov 21, 2024

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Nov 14, 2024

⚠️ Please don't merge until the Podfile is updated with a trunk version of WordPressKit.

Part of: woocommerce/woocommerce-ios#14419

This PR adds support for requesting the creation of the account when using WordPressComAccountService/requestAuthenticationLink, this allows using the same WPCom endpoint for sending magic link to both existing and new accounts.

Testing

Check woocommerce/woocommerce-ios#14431


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@hichamboushaba hichamboushaba force-pushed the magic-link-create-account branch from bac645f to ab26abe Compare November 14, 2024 14:55
@hichamboushaba hichamboushaba added the enhancement New feature or request label Nov 15, 2024
@hichamboushaba hichamboushaba marked this pull request as ready for review November 15, 2024 09:03
@hafizrahman hafizrahman self-assigned this Nov 18, 2024
Copy link

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good as it's simply getting the latest change from WordPressKit and using the new function from there.

@mokagio mokagio enabled auto-merge November 21, 2024 06:17
@mokagio
Copy link
Contributor

mokagio commented Nov 21, 2024

@hichamboushaba @hafizrahman

⚠️ Please don't merge until the Podfile is updated with a trunk version of WordPressKit.

I took over this PR fix the WordPressKit dependency wiring. I've enabled auto merge and will proceed to update WooCommerce to point to these changes once they land.

@mokagio mokagio merged commit cd53ee3 into trunk Nov 21, 2024
9 of 10 checks passed
@mokagio mokagio deleted the magic-link-create-account branch November 21, 2024 06:23
@jaclync jaclync mentioned this pull request Nov 22, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants