-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 9.0.7 #851
Release 9.0.7 #851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@@ -48,6 +48,12 @@ _None._ | |||
|
|||
_None._ | |||
|
|||
## 9.0.7 | |||
|
|||
### Bug Fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this title should be "Breaking Changes".
### Bug Fixes | |
### Breaking Changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I explained in the description:
I updated the CHANGELOG to make this fix a bug fix instead of breaking, because it doesn't make the hosting apps fails to compile.
If we want to keep it a breaking change, we would need to bump the version to a major number (10.0). I don't think this break the hosting apps, so I updated it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I explained in the description:
Sorry, I missed this.
I don't think this break the hosting apps, so I updated it.
This makes sense. 👍
Releasing a new version containing a fix for the site credential login to show social login options.
I updated the CHANGELOG to make this fix a bug fix instead of breaking, because it doesn't make the hosting apps fails to compile.
CHANGELOG.md
if necessary.