Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 9.0.7 #851

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Release 9.0.7 #851

merged 3 commits into from
Apr 12, 2024

Conversation

itsmeichigo
Copy link
Contributor

Releasing a new version containing a fix for the site credential login to show social login options.
I updated the CHANGELOG to make this fix a bug fix instead of breaking, because it doesn't make the hosting apps fails to compile.


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@@ -48,6 +48,12 @@ _None._

_None._

## 9.0.7

### Bug Fixes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this title should be "Breaking Changes".

Suggested change
### Bug Fixes
### Breaking Changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explained in the description:

I updated the CHANGELOG to make this fix a bug fix instead of breaking, because it doesn't make the hosting apps fails to compile.

If we want to keep it a breaking change, we would need to bump the version to a major number (10.0). I don't think this break the hosting apps, so I updated it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explained in the description:

Sorry, I missed this.

I don't think this break the hosting apps, so I updated it.

This makes sense. 👍

@itsmeichigo itsmeichigo merged commit 27a8280 into trunk Apr 12, 2024
10 checks passed
@itsmeichigo itsmeichigo deleted the release/9.0.7 branch April 12, 2024 07:18
@selanthiraiyan selanthiraiyan self-assigned this Apr 12, 2024
@itsmeichigo itsmeichigo restored the release/9.0.7 branch April 12, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants