Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WordPressKit version #79

Merged
merged 3 commits into from
Apr 11, 2019
Merged

Conversation

danielebogo
Copy link
Contributor

WordPressKit has been updated to the major version 4.0.0-beta.
This PR update the podspec and WordPressKit versions.
I also updatetd the Podfile and run a bundle exec pod install.

@danielebogo danielebogo added the enhancement New feature or request label Apr 11, 2019
@danielebogo danielebogo requested a review from jtreanor April 11, 2019 11:38
@danielebogo danielebogo self-assigned this Apr 11, 2019
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "WordPressAuthenticator"
s.version = "1.3.0"
s.version = "1.3.1-beta.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth calling this 1.4.0-beta.1 since it has a major version change to WPKit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let me fix it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtreanor done!

@danielebogo
Copy link
Contributor Author

Thanks @jtreanor !

@danielebogo danielebogo merged commit 759cfb3 into develop Apr 11, 2019
@danielebogo danielebogo deleted the fix/update-wp-kit-dependency branch April 11, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants