Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum version of WordPressKit dependency to 7.0 #754

Merged
merged 5 commits into from
Mar 17, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Mar 13, 2023

Related to wordpress-mobile/WordPressKit-iOS#581.

The version of WordPressKit library will be bumped to 7.0, so we need to also bump the minimum version of this dependency.


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@fluiddot fluiddot self-assigned this Mar 13, 2023
@fluiddot fluiddot changed the title Bump WordPressKit dependency 7.0 Bump minimum version of WordPressKit dependency to 7.0 Mar 13, 2023
Podfile Outdated Show resolved Hide resolved
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @fluiddot! 🚀

@fluiddot fluiddot marked this pull request as ready for review March 17, 2023 12:54
@fluiddot fluiddot force-pushed the bump-wpkit-dependency-7.0 branch from 3101e63 to 57cbe67 Compare March 17, 2023 13:05
@fluiddot
Copy link
Contributor Author

@twstokes heads up that I changed the podspec version to a beta version 5.6.0-beta.1.

@twstokes
Copy link
Contributor

@twstokes heads up that I changed the podspec version to a beta version 5.6.0-beta.1.

Sounds good @fluiddot!

@fluiddot fluiddot merged commit b89ade5 into trunk Mar 17, 2023
@fluiddot fluiddot deleted the bump-wpkit-dependency-7.0 branch March 17, 2023 16:45
mokagio added a commit that referenced this pull request Mar 20, 2023
Notice that while
#754
updated the minimum required WordPressKit dependency, it did not change
the project's public API. As such, we don't need to bump the major
version.

See also
https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants