-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum version of WordPressKit
dependency to 7.0
#754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
fluiddot
changed the title
Bump
Bump minimum version of Mar 13, 2023
WordPressKit
dependency 7.0WordPressKit
dependency to 7.0
fluiddot
commented
Mar 13, 2023
4 tasks
twstokes
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @fluiddot! 🚀
4 tasks
fluiddot
force-pushed
the
bump-wpkit-dependency-7.0
branch
from
March 17, 2023 13:05
3101e63
to
57cbe67
Compare
@twstokes heads up that I changed the |
mokagio
added a commit
that referenced
this pull request
Mar 20, 2023
Notice that while #754 updated the minimum required WordPressKit dependency, it did not change the project's public API. As such, we don't need to bump the major version. See also https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to wordpress-mobile/WordPressKit-iOS#581.
The version of
WordPressKit
library will be bumped to7.0
, so we need to also bump the minimum version of this dependency.CHANGELOG.md
if necessary.