Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK-less Google SignIn – Part 5 – Connect the pieces #743
SDK-less Google SignIn – Part 5 – Connect the pieces #743
Changes from 25 commits
03ff3dc
76dd45a
0eb0bbb
56fe71e
c9b0bb7
69bf8c4
ab9ab95
a134808
44a8f5c
a8c30e0
d6a8154
dffdd5d
1216c97
32bd679
6f2659e
ecf997c
18eb889
d4ed389
0607d2b
9af0e0f
923fa78
d5ed7eb
ecd5888
485b906
4a4e0ed
d1b6c91
3c49abd
76fd3c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
onSynced
is not called anywhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good eyes!
Addressed in d1b6c91
Thanks 🙇♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
presentAlert
give us any guarantees that it runs on the main thread?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find anything in the docs about whether the UIKit method runs on the main thread.
This is a custom method so we can definitely force it to run on the main thread.
However, I'm not sure why we would go to "such effort" in the context of the demo app? What am I missing?
FWIW, TSan doesn't complain in the successful branch of the
do catch
.