Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configuration flag to log custom step event for GetStartedViewController #724

Merged

Conversation

selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Jan 18, 2023

Closes #723

Description

Previously in #674 we introduced a new step value enter_email_address for GetStartedViewController .
This was added to differentiate between GetStartedViewController and SiteAddressViewController in Woo mobile app. Those two screens had the same flow and step value.

This new step value change has led to an issue with the WPiOS Looker dashboard (ref: pe5sF9-FU-p2#comment-1542).
To fix the issue, we are introducing a configuration flag in WordPressAuthenticatorConfiguration to use custom step event only when the useEnterEmailAddressAsStepValueForGetStartedVC flag is enabled.

Testing steps

Follow the testing instructions from

  1. WPAuthenticator - Config flag to enable custom step value for get started screen.  woocommerce/woocommerce-ios#8669
  2. WPAuthenticator - Remove custom step value from GetStartedViewController WordPress-iOS#19940

  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@selanthiraiyan selanthiraiyan changed the title Config flag to track custom step value Use configuration flag to log custom step event for GetStartedViewController Jan 18, 2023
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@selanthiraiyan selanthiraiyan merged commit fcf4d75 into trunk Jan 18, 2023
@selanthiraiyan selanthiraiyan deleted the feat/723-configuration-flag-for-woo-analytics-step branch January 18, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracks: Add new configuration to log enter_email_address step
2 participants