Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tracking event for XMLRPC error #701

Merged
merged 6 commits into from
Nov 9, 2022
Merged

New tracking event for XMLRPC error #701

merged 6 commits into from
Nov 9, 2022

Conversation

selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Nov 9, 2022 •
edited
Loading

Related to woocommerce/woocommerce-ios#8063

This PR adds a new event for tracking XMLRPC URL guessing failures.

Changes

  • New Failure enum to track failures.
  • Track loginFailedToGuessXMLRPC event when guessing XMLRPC fails.

Testing instructions

Please follow the testing instructions from - woocommerce/woocommerce-ios#8064

  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@selanthiraiyan selanthiraiyan mentioned this pull request Nov 9, 2022
Merged
2 tasks
@selanthiraiyan selanthiraiyan marked this pull request as ready for review November 9, 2022 05:34
@itsmeichigo itsmeichigo self-assigned this Nov 9, 2022
itsmeichigo
itsmeichigo approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! :shipit:

@selanthiraiyan selanthiraiyan merged commit fb0f2c0 into trunk Nov 9, 2022
@selanthiraiyan selanthiraiyan deleted the wcios/trackXmlrpcError branch November 9, 2022 10:09
@oguzkocer oguzkocer mentioned this pull request Nov 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

@jaclync jaclync Awaiting requested review from jaclync

Assignees

@itsmeichigo itsmeichigo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@selanthiraiyan @itsmeichigo