Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Flickering navigation bar when going back to LoginPrologueViewController with interactive gesture #585

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fix: Flickering navigation bar when going back to LoginPrologueViewController with interactive gesture #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WordPressAuthenticator/Signin/LoginPrologueViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class LoginPrologueViewController: LoginViewController {
super.viewWillAppear(animated)

configureButtonVC()
navigationController?.setNavigationBarHidden(true, animated: false)
navigationController?.setNavigationBarHidden(true, animated: animated)
}

override func viewDidAppear(_ animated: Bool) {
Expand Down
6 changes: 3 additions & 3 deletions ...PressAuthenticator/Unified Auth/View Related/Site Address/SiteAddressViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ final class SiteAddressViewController: LoginViewController {

siteURLField?.text = loginFields.siteAddress
configureSubmitButton(animating: false)

// Nav bar could be hidden from the host app, so reshow it.
navigationController?.setNavigationBarHidden(false, animated: animated)
}

override func viewDidAppear(_ animated: Bool) {
Expand Down Expand Up @@ -232,9 +235,6 @@ private extension SiteAddressViewController {
func configureNavBar() {
navigationItem.title = WordPressAuthenticator.shared.displayStrings.logInTitle
styleNavigationBar(forUnified: true)

// Nav bar could be hidden from the host app, so reshow it.
navigationController?.setNavigationBarHidden(false, animated: false)
}

func setupTable() {
Expand Down